Skip to content

plugin(apm-data): amend logs-apm component template #115778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2024
Merged

plugin(apm-data): amend logs-apm component template #115778

merged 2 commits into from
Oct 28, 2024

Conversation

@inge4pres
Copy link
Contributor

Restore standard mode after LogsDB took precedence. Related: #114501

  • Have you signed the contributor license agreement? ✅
  • Have you followed the contributor guidelines? ✅
  • If submitting code, have you built your formula locally prior to submission with gradle check? 🚫
  • If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. ✅
  • If submitting code, have you checked that your submission is for an OS and architecture that we support? ✅

@inge4pres
plugin(apm-data): amend logs-apm component template
cced819 
Restore standard mode after LogsDB took precedence.
Related: #114501
@inge4pres inge4pres requested a review from a team as a code owner October 28, 2024 14:45
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.0.0 labels Oct 28, 2024
@inge4pres inge4pres added Team:obs-ds-intake-services Meta label for Observability Intake Services team and removed needs:triage Requires assignment of a team area label v9.0.0 labels Oct 28, 2024
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label and removed Team:obs-ds-intake-services Meta label for Observability Intake Services team labels Oct 28, 2024
lahsivjar
lahsivjar approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@lahsivjar lahsivjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@inge4pres inge4pres added the Team:obs-ds-intake-services Meta label for Observability Intake Services team label Oct 28, 2024
@elasticsearchmachine elasticsearchmachine removed the Team:obs-ds-intake-services Meta label for Observability Intake Services team label Oct 28, 2024
@inge4pres
Copy link
Contributor Author

What's the right labels sorcery here?

@lahsivjar lahsivjar added the :Data Management/Data streams Data streams and their lifecycles label Oct 28, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Oct 28, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Oct 28, 2024
@lahsivjar
Copy link
Contributor

@inge4pres Do we need to backport this? Seems to only affect serverless so not needed I think but maybe we should backport.

@inge4pres
Copy link
Contributor Author

inge4pres commented Oct 28, 2024 •
edited
Loading

Do we need to backport this?

Seems like no, as long as #114501 is not going to land in 8.x too as-is.
Yes, I just checked 8.x is affected as well.
https://github.com/elastic/elasticsearch/blob/b88e9a69473b3aced24e52e19b958238cab1e61e/x-pack/plugin/apm-data/src/main/resources/component-templates/logs-apm%40settings.yaml

@lahsivjar do you know which labels need to be added for the backport?

@inge4pres inge4pres added >bug needs:triage Requires assignment of a team area label Team:obs-ds-intake-services Meta label for Observability Intake Services team v9.0.0 and removed >enhancement :Data Management/Data streams Data streams and their lifecycles Team:Data Management Meta label for data/management team labels Oct 28, 2024
@inge4pres inge4pres removed the needs:triage Requires assignment of a team area label label Oct 28, 2024
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label and removed Team:obs-ds-intake-services Meta label for Observability Intake Services team labels Oct 28, 2024
@inge4pres inge4pres added the Team:obs-ds-intake-services Meta label for Observability Intake Services team label Oct 28, 2024
@elasticsearchmachine elasticsearchmachine removed the Team:obs-ds-intake-services Meta label for Observability Intake Services team label Oct 28, 2024
@inge4pres inge4pres added auto-backport Automatically create backport pull requests when merged v8.16.0 labels Oct 28, 2024
@salvatore-campagna salvatore-campagna removed the needs:triage Requires assignment of a team area label label Oct 28, 2024
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Oct 28, 2024
@inge4pres inge4pres added :Data Management/Data streams Data streams and their lifecycles Team:obs-ds-intake-services Meta label for Observability Intake Services team labels Oct 28, 2024
@elasticsearchmachine elasticsearchmachine added Team:Data Management Meta label for data/management team and removed needs:triage Requires assignment of a team area label Team:obs-ds-intake-services Meta label for Observability Intake Services team labels Oct 28, 2024
@inge4pres inge4pres merged commit 2b1dc5a into main Oct 28, 2024
17 checks passed
@inge4pres inge4pres deleted the inge4pres-patch-1 branch October 28, 2024 16:47
@inge4pres inge4pres mentioned this pull request Oct 30, 2024
Merged
inge4pres added a commit to inge4pres/elasticsearch that referenced this pull request Oct 30, 2024
@inge4pres
plugin(apm-data): amend logs-apm component template (elastic#115778)
5a7ced7 
Restore standard mode after LogsDB took precedence.
Related: elastic#114501

(cherry picked from commit 2b1dc5a)
inge4pres added a commit that referenced this pull request Oct 30, 2024
@inge4pres
plugin(apm-data): amend logs-apm component template (#115778) (#115924)
eeca7aa 
Restore standard mode after LogsDB took precedence.
Related: #114501

(cherry picked from commit 2b1dc5a)
ioanatia pushed a commit to ioanatia/elasticsearch that referenced this pull request Nov 4, 2024
@inge4pres @ioanatia
plugin(apm-data): amend logs-apm component template (elastic#115778)
96a73bf 
Restore standard mode after LogsDB took precedence.
Related: elastic#114501
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Nov 4, 2024
@inge4pres @jfreden
plugin(apm-data): amend logs-apm component template (elastic#115778)
dda6f24 
Restore standard mode after LogsDB took precedence.
Related: elastic#114501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martijnvg martijnvg martijnvg left review comments

@lahsivjar lahsivjar lahsivjar approved these changes

+2 more reviewers

@1pkg 1pkg 1pkg approved these changes

@salvatore-campagna salvatore-campagna salvatore-campagna approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged >bug :Data Management/Data streams Data streams and their lifecycles Team:Data Management Meta label for data/management team v8.16.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@inge4pres @elasticsearchmachine @lahsivjar @martijnvg @1pkg @salvatore-campagna