KQL update tests #116483
Merged
KQL update tests #116483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afoucret
added
>non-issue
auto-backport
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
tteofili
approved these changes
Nov 8, 2024
carlosdelest
approved these changes
Nov 8, 2024
ioanatia
approved these changes
Nov 8, 2024
| foo_*_field:foo | ||
| foo_field:* | ||
| foo_*:* | ||
| mapped_int:200 |
Contributor
There was a problem hiding this comment.
I would have named these int_field, text_field etc - but these were already added in AbstractBuilderTestCase a long time ago, so it's all good.
Contributor
Author
There was a problem hiding this comment.
I would also prefer it but it is inherited, so I have to deal with these names 😿
| mapping.field("type", "nested"); | ||
| mapping.startObject("properties"); | ||
| { | ||
| mapping.startObject(TEXT_FIELD_NAME).field("type", "text").endObject(); |
Collaborator
💚 Backport successful
|
afoucret
added a commit
to afoucret/elasticsearch
that referenced
this pull request
Nov 8, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 8, 2024
jozala
pushed a commit
that referenced
this pull request
Nov 13, 2024
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the KQL tests to prepare the implementation of nested field support.
More specifically it does:
supported-queriesandunsupported-queries