Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Lucene 5.2.1. #11662

Merged
merged 2 commits into from Jun 15, 2015

Conversation

@jpountz
Copy link
Contributor

commented Jun 15, 2015

I have one remaining nocommit to fix in SimpleLuceneTests because of DirectoryReader.openIfChanged returning a non-null reader after IndexWriter.prepareCommit has been called. I'll dig.

@jpountz

This comment has been minimized.

Copy link
Contributor Author

commented Jun 15, 2015

This looks related to LUCENE-6523 but I'm not sure yet if this is the expected behaviour or if it hides a bug.

It is unnecessary to test features we are not using.
@jpountz

This comment has been minimized.

Copy link
Contributor Author

commented Jun 15, 2015

Since we don't use prepareCommit in Elasticsearch, I removed this test and opened https://issues.apache.org/jira/browse/LUCENE-6565. I think it's ready now.

@mikemccand

This comment has been minimized.

Copy link
Contributor

commented Jun 15, 2015

LGTM

jpountz added a commit that referenced this pull request Jun 15, 2015
@jpountz jpountz merged commit 56c7cce into elastic:master Jun 15, 2015
1 check passed
1 check passed
CLA Commit author is a member of Elasticsearch
Details
@kevinkluge kevinkluge removed the review label Jun 15, 2015
@jpountz jpountz deleted the jpountz:upgrade/lucene-5.2.1 branch Jun 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.