Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Do not prompt for node name twice #11668
We allow setting the node's name a few different ways: the
This fix changes the behavior to only prompt once when
I pulled and built this branch and then tested and it worked. LGTM, thanks for fixing this.
We allow setting the node's name a few different ways: the `name` system property, the setting `name`, and the setting `node.name`. There is an order of preference to these settings that gets applied, which can copy values from the system property or `node.name` setting to the `name` setting. When setting only `node.name` to one of the prompt placeholders, the user would be prompted twice as the value of `node.name` is copied to `name` prior to prompting for input. Additionally, the value entered by the user for `node.name` would not be used and only the value entered for `name` would be used. This fix changes the behavior to only prompt once when `node.name is set` and `name` is not set. This is accomplished by waiting until all values have been prompted and replaced, then the logic for determining the node's name is executed. Closes #11564