Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace fieldType access in mappers with getter #11764

Merged
merged 1 commit into from Jun 18, 2015

Conversation

Projects
None yet
3 participants
@rjernst
Copy link
Member

commented Jun 18, 2015

A small refactoring to allow changing how the field type is stored later.

Mappings: Replace fieldType access in mappers with getter
A small refactoring to allow changing how the field type is stored later.
@s1monw

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2015

LGTM

rjernst added a commit that referenced this pull request Jun 18, 2015

Merge pull request #11764 from rjernst/fix/field-type-ref
Replace fieldType access in mappers with getter

@rjernst rjernst merged commit bfc4b8d into elastic:master Jun 18, 2015

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@rjernst rjernst deleted the rjernst:fix/field-type-ref branch Jun 18, 2015

rjernst added a commit to rjernst/elasticsearch that referenced this pull request Jun 18, 2015

Mappings: Hide more fieldType access and cleanup null_value merging
There were some missed uses of AbstractFieldMapper.fieldType in elastic#11764.
This change also moves null_value merging into AbstractFieldMapper.

rjernst added a commit to rjernst/elasticsearch that referenced this pull request Jun 19, 2015

Mappings: Hide more fieldType access and cleanup null_value merging
There were some missed uses of AbstractFieldMapper.fieldType in elastic#11764.
This change also moves null_value merging into AbstractFieldMapper.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.