More realistic test scenario in Authc service test #118519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes `AuthenticationServiceTests.testInvalidToken` to configure the security (tokens) index correctly. Previously `defensiveCopy()` would return `null` which would cause `getTokenDocById` to throw an exception, which `decodeToken` would catch and ignore. But that is not a realistic scenario, and is testing by side-effect.
elasticsearchmachine
added
v9.0.0
needs:triage
tvernum
added
>test
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
Contributor
Author
|
I have a refactor of the security index manager on another branch, and on that branch the test actually fails because the incorrect usage triggers an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
AuthenticationServiceTests.testInvalidTokento configure the security (tokens) index correctly.Previously
defensiveCopy()would returnnullwhich would causegetTokenDocByIdto throw an exception, whichdecodeTokenwould catch and ignore.But that is not a realistic scenario, and is testing by side-effect.