Skip to content

Conversation

@jdconrad
Copy link
Contributor

We expect exactly 4 stack frames for our entitlement checks when fetching the module we want to check the policy for. When adding entitlement checks for specific JDK versions we cannot call super or we increase that number to 5 stack frames which causes entitlement failures. This removes the super call and instead calls call policy manager directly.

@jdconrad jdconrad added >bug :Core/Infra/Plugins Plugin API and infrastructure auto-backport Automatically create backport pull requests when merged v9.0.0 v8.18.0 test-entitlements labels Dec 18, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Dec 18, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @jdconrad, I've created a changelog YAML for you.

@jdconrad jdconrad requested a review from rjernst December 18, 2024 00:44
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdconrad
Copy link
Contributor Author

Closing in favor of (#118983)

@jdconrad jdconrad closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged >bug :Core/Infra/Plugins Plugin API and infrastructure Team:Core/Infra Meta label for core/infra team v8.18.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants