Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't special-case on ElasticsearchWrapperException in toXContent #12015

Merged
merged 1 commit into from Jul 3, 2015

Conversation

Projects
None yet
4 participants
@s1monw
Copy link
Contributor

commented Jul 3, 2015

the specialization can cause stack overflows if an exception is a
ElasticsearchWrapperException as well as a ElasticsearchException.
This commit just relies on the unwrap logic now to find the cause and only
renders if we the rendering exception is the cause otherwise forwards
to the generic exception rendering.

Closes #11994

@s1monw s1monw added the review label Jul 3, 2015

@colings86

This comment has been minimized.

Copy link
Member

commented Jul 3, 2015

LGTM

Don't special-case on ElasticsearchWrapperException in toXContent
the specialization can cause stack overflows if an exception is a
ElasticsearchWrapperException as well as a ElasticsearchException.
This commit just relies on the unwrap logic now to find the cause and only
renders if we the rendering exception is the cause otherwise forwards
to the generic exception rendering.

Closes #11994

@s1monw s1monw force-pushed the s1monw:issues/11994 branch to ac32f3d Jul 3, 2015

@s1monw s1monw merged commit ac32f3d into elastic:master Jul 3, 2015

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@s1monw s1monw removed the review label Jul 3, 2015

@s1monw s1monw deleted the s1monw:issues/11994 branch Jul 3, 2015

@lcawl lcawl added :Core/Infra/Core and removed :Exceptions labels Feb 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.