Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZenDiscovery: #11960 failed to remove eager reroute from node join #12019

Closed

Conversation

Projects
None yet
3 participants
@bleskes
Copy link
Member

commented Jul 3, 2015

This commit fixes it and adds an assert that an initial cluster state from master never has shards assigned to this node

ZenDiscovery: #11960 failed to remove eager reroute from node join
This commit fixes it and adds an assert that an initial cluster state from master never has shards assigned to this node

@bleskes bleskes force-pushed the bleskes:fix_zen_discovery_node_join_1190 branch to 4c04ed4 Jul 3, 2015

@kimchy

This comment has been minimized.

Copy link
Member

commented Jul 3, 2015

LGTM

@bleskes bleskes closed this in d74eac9 Jul 3, 2015

@kevinkluge kevinkluge removed the review label Jul 3, 2015

bleskes added a commit that referenced this pull request Jul 3, 2015

@bleskes

This comment has been minimized.

Copy link
Member Author

commented Jul 3, 2015

pushed to 2.0 & 1.x . Had to remove the assertion as there is a case where the joining node will have shards assigned to it upon first publish - i.e., a master failure followed by another master publishing it's last known state.

@bleskes bleskes deleted the bleskes:fix_zen_discovery_node_join_1190 branch Jul 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.