Replace LegacyGeoShapeWithDocValuesIT with unit tests #120266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes LegacyGeoShapeWithDocValuesIT which contains two specific test for legacy "geo_shape" mappings that can still be used in version 7 indices. The functionality checked in covered by "testMappingUpdate" should be covered by GeoShapeWithDocValuesFieldMapperTests#testGeoShapeLegacyMerge already, the test with a Circle shape is moved to GeoShapeWithDocValuesFieldMapperTests.
cbuescher
added
>test
elasticsearchmachine
added
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
cbuescher
commented
Jan 16, 2025
...alClusterTest/java/org/elasticsearch/xpack/spatial/search/LegacyGeoShapeWithDocValuesIT.java
Show resolved
Hide resolved
javanna
approved these changes
Jan 16, 2025
iverase
approved these changes
Jan 16, 2025
cbuescher
commented
Jan 16, 2025
...alClusterTest/java/org/elasticsearch/xpack/spatial/search/LegacyGeoShapeWithDocValuesIT.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes LegacyGeoShapeWithDocValuesIT which contains two specific test for legacy "geo_shape" mappings that can still be used in version 7 indices. The functionality checked in covered by "testMappingUpdate" should be covered by GeoShapeWithDocValuesFieldMapperTests#testGeoShapeLegacyMerge already, the test with a Circle shape is moved to
GeoShapeWithDocValuesFieldMapperTests.