Skip to content

Increase time in IntervalThrottlerTests #120344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 18, 2025
Merged

Increase time in IntervalThrottlerTests #120344

merged 4 commits into from
Jan 18, 2025

Conversation

@limotova
Copy link
Contributor

We suspect that something in the test environment is causing more than
10ms to pass between some of the calls so increasing to 100 to verify.

Closes #120023

@limotova
Increase time in IntervalThrottlerTests
325144f 
We suspect that something in the test environment is causing more than
10ms to pass between some of the calls so increasing to 100 for now to
verify

Closes elastic#120023
@limotova limotova requested a review from kkrik-es January 17, 2025 06:41
@limotova limotova marked this pull request as ready for review January 17, 2025 06:41
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Jan 17, 2025
kkrik-es
kkrik-es approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@kkrik-es kkrik-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, if we still get noise we'll remove the second assertFalse.

@limotova limotova added Team:StorageEngine :StorageEngine/Mapping The storage related side of mappings labels Jan 17, 2025
@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Jan 17, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@limotova limotova added >test Issues or PRs that are addressing/adding tests needs:triage Requires assignment of a team area label auto-backport Automatically create backport pull requests when merged v8.18.0 labels Jan 17, 2025
@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Jan 17, 2025
@limotova limotova merged commit 2c3a0f5 into elastic:main Jan 18, 2025
16 checks passed
@limotova limotova deleted the increase-intervalMillis-in-throttling-test branch January 18, 2025 02:12
@limotova limotova mentioned this pull request Jan 18, 2025
Closed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 120344

elasticsearchmachine pushed a commit that referenced this pull request Jan 22, 2025
@limotova
Increase time in IntervalThrottlerTests (#120344) (#120574)
280ab31 
We suspect that something in the test environment is causing more than
10ms to pass between some of the calls so increasing to 100 for now to
verify

Closes #120023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kkrik-es kkrik-es kkrik-es approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged :StorageEngine/Mapping The storage related side of mappings Team:StorageEngine >test Issues or PRs that are addressing/adding tests v8.18.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] IntervalThrottlerTests testThrottling failing

3 participants

@limotova @elasticsearchmachine @kkrik-es