From 359e92108d2b78044af3ddd1f6f6458befd6e93d Mon Sep 17 00:00:00 2001 From: Armin Braun Date: Fri, 17 Jan 2025 16:08:21 +0100 Subject: [PATCH] Remove redundant load from SumAggregator (#120383) Trivial follow up to #120241, no need for a redundant load though the not-load path is probably very cold anyway, but still better to give the compiler all the inputs it can get. --- .../search/aggregations/metrics/SumAggregator.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/src/main/java/org/elasticsearch/search/aggregations/metrics/SumAggregator.java b/server/src/main/java/org/elasticsearch/search/aggregations/metrics/SumAggregator.java index eca28396e3274..c8b364c08bec5 100644 --- a/server/src/main/java/org/elasticsearch/search/aggregations/metrics/SumAggregator.java +++ b/server/src/main/java/org/elasticsearch/search/aggregations/metrics/SumAggregator.java @@ -83,9 +83,9 @@ public void collect(int doc, long bucket) throws IOException { value = v + value; } - var compensations = SumAggregator.this.compensations; - double delta = compensations.get(bucket); if (Double.isFinite(value)) { + var compensations = SumAggregator.this.compensations; + double delta = compensations.get(bucket); double correctedSum = v + delta; double updatedValue = value + correctedSum; delta = correctedSum - (updatedValue - value);