New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Prepare plugin and integration docs for 2.0 #12040

Merged
merged 1 commit into from Aug 15, 2015

Conversation

Projects
None yet
6 participants
@clintongormley
Member

clintongormley commented Jul 5, 2015

  • Centralised plugin docs in docs/plugins/
  • Moved integrations into same docs
  • Moved community clients into the clients section of the docs
  • Removed docs/community

Closes #11734
Closes #11724
Closes #11636
Closes #11635
Closes #11632
Closes #11630
Closes #12046
Closes #12438
Closes #12579

@dadoonet

View changes

Show outdated Hide outdated docs/plugins/plugin-script.asciidoc
@dadoonet

View changes

Show outdated Hide outdated docs/plugins/plugin-script.asciidoc
@dadoonet

View changes

Show outdated Hide outdated docs/plugins/plugin-script.asciidoc
@dadoonet

View changes

Show outdated Hide outdated docs/plugins/plugin-script.asciidoc
@dadoonet

View changes

Show outdated Hide outdated docs/plugins/plugin-script.asciidoc
@dadoonet

View changes

Show outdated Hide outdated docs/plugins/plugin-script.asciidoc
@dadoonet

View changes

Show outdated Hide outdated docs/plugins/plugin-script.asciidoc
@dadoonet

View changes

Show outdated Hide outdated docs/plugins/plugin-script.asciidoc
@dadoonet

View changes

Show outdated Hide outdated docs/plugins/plugin-script.asciidoc
@dadoonet

View changes

Show outdated Hide outdated docs/plugins/plugin-script.asciidoc
@dadoonet

View changes

Show outdated Hide outdated docs/plugins/plugin-script.asciidoc
@dadoonet

View changes

Show outdated Hide outdated docs/plugins/plugin-script.asciidoc
@dadoonet

View changes

Show outdated Hide outdated docs/plugins/plugin-script.asciidoc
@dadoonet

View changes

Show outdated Hide outdated docs/plugins/plugin-script.asciidoc
@dadoonet

View changes

Show outdated Hide outdated docs/plugins/plugin-script.asciidoc
@dadoonet

View changes

Show outdated Hide outdated docs/plugins/alerting.asciidoc
@dadoonet

View changes

Show outdated Hide outdated docs/plugins/management.asciidoc
link:/products/shield[Shield]::
Shield is the Elastic product that makes it easy for anyone to add

This comment has been minimized.

@dadoonet

dadoonet Jul 5, 2015

Member

Same as for watcher. I think we should say here that it's a commercial product. As you did for Marvel BTW.

@dadoonet

dadoonet Jul 5, 2015

Member

Same as for watcher. I think we should say here that it's a commercial product. As you did for Marvel BTW.

@dadoonet

This comment has been minimized.

Show comment
Hide comment
@dadoonet

dadoonet Jul 5, 2015

Member

I left some comments. I really like how the documentation is now rendered using same look and feel than the core documentation. With sections... Really great improvement. And searchable I guess! \o/

While reading the documentation, I was also thinking of something which is out of the scope of this PR.

I think that we should split "cloud" plugins in "discovery" plugins and "repository" plugins. They are serving different purposes. It appears really clearly when you read the documentation...
And there is not really common code between the 2 features. But this is something we can talk about in the future :)

Member

dadoonet commented Jul 5, 2015

I left some comments. I really like how the documentation is now rendered using same look and feel than the core documentation. With sections... Really great improvement. And searchable I guess! \o/

While reading the documentation, I was also thinking of something which is out of the scope of this PR.

I think that we should split "cloud" plugins in "discovery" plugins and "repository" plugins. They are serving different purposes. It appears really clearly when you read the documentation...
And there is not really common code between the 2 features. But this is something we can talk about in the future :)

@clintongormley

This comment has been minimized.

Show comment
Hide comment
@clintongormley

clintongormley Jul 5, 2015

Member

thanks for the review @dadoonet - i've fixed the errors.

Member

clintongormley commented Jul 5, 2015

thanks for the review @dadoonet - i've fixed the errors.

@clintongormley

This comment has been minimized.

Show comment
Hide comment
@clintongormley

clintongormley Jul 5, 2015

Member

waiting for a review from @skearns64

Member

clintongormley commented Jul 5, 2015

waiting for a review from @skearns64

@dadoonet

This comment has been minimized.

Show comment
Hide comment
@dadoonet

dadoonet Jul 5, 2015

Member

@clintongormley I commented again. Apart from that it looks good to me.

Member

dadoonet commented Jul 5, 2015

@clintongormley I commented again. Apart from that it looks good to me.

@skearns64

View changes

Show outdated Hide outdated docs/community-clients/index.asciidoc
@skearns64

View changes

Show outdated Hide outdated docs/plugins/alerting.asciidoc
@skearns64

View changes

Show outdated Hide outdated docs/plugins/cloud-gce.asciidoc
@skearns64

View changes

Show outdated Hide outdated docs/plugins/cloud-gce.asciidoc
@skearns64

This comment has been minimized.

Show comment
Hide comment
@skearns64

skearns64 Jul 5, 2015

Contributor

This is an awesome re-org; it's going to make things a lot easier to find.
I left a few minor comments, suggestions, and questions, but other than that, LGTM.

Contributor

skearns64 commented Jul 5, 2015

This is an awesome re-org; it's going to make things a lot easier to find.
I left a few minor comments, suggestions, and questions, but other than that, LGTM.

@nik9000

View changes

Show outdated Hide outdated docs/community-clients/index.asciidoc
@nik9000

View changes

Show outdated Hide outdated docs/community-clients/index.asciidoc
@nik9000

View changes

Show outdated Hide outdated docs/community-clients/index.asciidoc
@nik9000

View changes

Show outdated Hide outdated docs/community-clients/index.asciidoc
Results clustering with http://project.carrot2.org/[carrot2] (by Dawid Weiss)
* https://github.com/wikimedia/search-extra[Elasticsearch Trigram Accelerated Regular Expression Filter]:
(by Wikimedia Foundation/Nik Everett)

This comment has been minimized.

@nik9000

nik9000 Jul 27, 2015

Contributor

s/Wikimedia Foundation/Nik Everett/Wikimedia Foundation/

@nik9000

nik9000 Jul 27, 2015

Contributor

s/Wikimedia Foundation/Nik Everett/Wikimedia Foundation/

@nik9000

View changes

Show outdated Hide outdated docs/plugins/api.asciidoc
@nik9000

View changes

Show outdated Hide outdated docs/plugins/repository.asciidoc
@nik9000

This comment has been minimized.

Show comment
Hide comment
@nik9000

nik9000 Jul 27, 2015

Contributor

Reviewed. For the most part it looks fine. Just left a few small changes which can totally go in other pull requests.

Contributor

nik9000 commented Jul 27, 2015

Reviewed. For the most part it looks fine. Just left a few small changes which can totally go in other pull requests.

Docs: Prepare plugin and integration docs for 2.0
* Centralised plugin docs in docs/plugins/
* Moved integrations into same docs
* Moved community clients into the clients section of the docs
* Removed docs/community

Closes #11734
Closes #11724
Closes #11636
Closes #11635
Closes #11632
Closes #11630
Closes #12046
Closes #12438
Closes #12579

clintongormley added a commit that referenced this pull request Aug 15, 2015

Merge pull request #12040 from clintongormley/plugin_docs
Docs: Prepare plugin and integration docs for 2.0

@clintongormley clintongormley merged commit f635f7e into elastic:master Aug 15, 2015

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@clintongormley clintongormley deleted the clintongormley:plugin_docs branch Aug 15, 2015

clintongormley added a commit that referenced this pull request Aug 15, 2015

Merge pull request #12040 from clintongormley/plugin_docs
Docs: Prepare plugin and integration docs for 2.0

@jpountz jpountz added v2.0.0-beta1 and removed v2.0.0 labels Aug 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment