From dcf9debae14ea6f42c1df4fbd8f425b8e689393b Mon Sep 17 00:00:00 2001 From: Nik Everett Date: Mon, 3 Feb 2025 16:02:30 -0500 Subject: [PATCH 1/2] ESQL: Reenable heap attacks (#121565) Reenables some heap attack tests, bumping their memory requirements to try and force a failure on all CI machines. Previously some CI machines weren't failing, invalidating the test on those machines. Close #121481 Close #121465 --- .../elasticsearch/xpack/esql/heap_attack/HeapAttackIT.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/test/external-modules/esql-heap-attack/src/javaRestTest/java/org/elasticsearch/xpack/esql/heap_attack/HeapAttackIT.java b/test/external-modules/esql-heap-attack/src/javaRestTest/java/org/elasticsearch/xpack/esql/heap_attack/HeapAttackIT.java index 59ce3c2dbb1cf..aaea04997bf3b 100644 --- a/test/external-modules/esql-heap-attack/src/javaRestTest/java/org/elasticsearch/xpack/esql/heap_attack/HeapAttackIT.java +++ b/test/external-modules/esql-heap-attack/src/javaRestTest/java/org/elasticsearch/xpack/esql/heap_attack/HeapAttackIT.java @@ -636,7 +636,8 @@ public void testLookupExplosion() throws IOException { public void testLookupExplosionManyMatches() throws IOException { assertCircuitBreaks(() -> { - Map result = lookupExplosion(1500, 10000); + // 1500, 10000 is enough locally, but some CI machines need more. + Map result = lookupExplosion(2000, 10000); logger.error("should have failed but got {}", result); }); } @@ -664,7 +665,8 @@ public void testLookupExplosionBigString() throws IOException { public void testLookupExplosionBigStringManyMatches() throws IOException { assertCircuitBreaks(() -> { - Map result = lookupExplosionBigString(500, 1); + // 500, 1 is enough to make it fail locally but some CI needs more + Map result = lookupExplosionBigString(800, 1); logger.error("should have failed but got {}", result); }); } From a3c8436504143ea7f56b329d2403445ef36fc976 Mon Sep 17 00:00:00 2001 From: Alexander Spies Date: Tue, 4 Feb 2025 12:13:05 +0100 Subject: [PATCH 2/2] Unmute --- muted-tests.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/muted-tests.yml b/muted-tests.yml index 0ef6db2b1dd89..7722d306d063c 100644 --- a/muted-tests.yml +++ b/muted-tests.yml @@ -545,9 +545,6 @@ tests: issue: https://github.com/elastic/elasticsearch/issues/121179 - class: org.elasticsearch.xpack.application.CohereServiceUpgradeIT issue: https://github.com/elastic/elasticsearch/issues/121537 -- class: org.elasticsearch.xpack.esql.heap_attack.HeapAttackIT - method: testLookupExplosionBigStringManyMatches - issue: https://github.com/elastic/elasticsearch/issues/121465 - class: org.elasticsearch.smoketest.DocsClientYamlTestSuiteIT method: test {yaml=reference/snapshot-restore/apis/get-snapshot-api/line_488} issue: https://github.com/elastic/elasticsearch/issues/121611