Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only clear open search ctx if the index is delete or closed via API #12199

Merged
merged 1 commit into from Jul 13, 2015

Conversation

@s1monw
Copy link
Contributor

commented Jul 13, 2015

A change in #12116 introduces closing / cleaning of search ctx even if
the index service was closed due to a relocation of it's last shard. This
is not desired since in that case it's fine to serve the pending requests from
the relocated shard. This commit adds an extra check to ensure that the index is
either removed (delete) or closed via API.

there where some failures related to this on CI here:

http://build-us-00.elastic.co/job/es_core_17_centos/50/

@s1monw

This comment has been minimized.

Copy link
Contributor Author

commented Jul 13, 2015

@martijnvg can you take a look at this

@martijnvg

This comment has been minimized.

Copy link
Member

commented Jul 13, 2015

@s1monw that was a sneaky failure. checking the MetaData to see if the index got closed via close api is the right way imo. LGTM

A change in #12116 introduces closing / cleaning of search ctx even if
the index service was closed due to a relocation of it's last shard. This
is not desired since in that case it's fine to serve the pending requests from
the relocated shard. This commit adds an extra check to ensure that the index is
either removed (delete) or closed via API.
@s1monw s1monw force-pushed the s1monw:clearn_on_real_close branch to 2e2bb25 Jul 13, 2015
@s1monw s1monw merged commit 2e2bb25 into elastic:master Jul 13, 2015
1 check passed
1 check passed
CLA Commit author is a member of Elasticsearch
Details
@s1monw s1monw deleted the s1monw:clearn_on_real_close branch Jul 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.