Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrefixQueryParser takes a String as value like its Builder #12204

Closed

Conversation

@alexksikes
Copy link
Contributor

commented Jul 13, 2015

Relates #12032

@alexksikes

This comment has been minimized.

Copy link
Contributor Author

commented Jul 15, 2015

@jpountz can you please have a look at this?

@@ -73,7 +73,7 @@ public Query parse(QueryParseContext parseContext) throws IOException, QueryPars
if ("_name".equals(currentFieldName)) {
queryName = parser.text();
} else if ("value".equals(currentFieldName) || "prefix".equals(currentFieldName)) {
value = parser.objectBytes();
value = parser.textOrNull();

This comment has been minimized.

Copy link
@javanna

javanna Jul 15, 2015

Member

same as in the regex PR, I wonder if we should have parser.text() or parser.textOrNull()

This comment has been minimized.

Copy link
@alexksikes

alexksikes Jul 15, 2015

Author Contributor

reasoning here is that we check for null at the end and return a probably more comprehensive error message.

This comment has been minimized.

Copy link
@jpountz

jpountz Jul 15, 2015

Contributor

makes sense to me

@jpountz

This comment has been minimized.

Copy link
Contributor

commented Jul 15, 2015

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.