Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrict the test unicast zen discovery to the port range of the JVM #12271

Merged
merged 1 commit into from Jul 15, 2015

Conversation

jaymode
Copy link
Member

@jaymode jaymode commented Jul 15, 2015

Today, the unicast zen test configuration will try to find a open port starting at the internal test cluster's
base port and continuing for 1000 ports. The internal test cluster class assigns a port range of 100 ports
to each JVM. This means that the unicast zen test configuration will try ports in the range for another JVM
and can lead to port conflicts. This change uses the same value for both so that the unicast configuration
does not go into another JVM's port range.

Today, the unicast zen test configuration will try to find a open port starting at the internal test cluster's
base port and continuing for 1000 ports. The internal test cluster class assigns a port range of 100 ports
to each JVM. This means that the unicast zen test configuration will try ports in the range for another JVM
and can lead to port conflicts. This change uses the same value for both so that the unicast configuration
does not go into another JVM's port range.
@jaymode jaymode added >test Issues or PRs that are addressing/adding tests v2.0.0-beta1 review labels Jul 15, 2015
@bleskes
Copy link
Contributor

bleskes commented Jul 15, 2015

LGTM. Any concrete failures explained by this?

jaymode added a commit that referenced this pull request Jul 15, 2015
restrict the test unicast zen discovery to the port range of the JVM
@jaymode jaymode merged commit 5091a10 into elastic:master Jul 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>test Issues or PRs that are addressing/adding tests v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants