Skip to content

Improve Iterators.single #122875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Improve Iterators.single #122875

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 18 additions & 14 deletions server/src/main/java/org/elasticsearch/common/collect/Iterators.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,22 +34,27 @@ public class Iterators {
* Returns a single element iterator over the supplied value.
*/
public static <T> Iterator<T> single(T element) {
return new Iterator<>() {
return new SingleIterator<>(element);
}

private T value = Objects.requireNonNull(element);
private static final class SingleIterator<T> implements Iterator<T> {
private T value;

@Override
public boolean hasNext() {
return value != null;
}
SingleIterator(T element) {
value = Objects.requireNonNull(element);
}

@Override
public T next() {
final T res = value;
value = null;
return res;
}
};
@Override
public boolean hasNext() {
return value != null;
}

@Override
public T next() {
final T res = value;
value = null;
return res;
}
}

@SafeVarargs
Expand Down Expand Up @@ -496,5 +501,4 @@ public static <T> int hashCode(Iterator<? extends T> iterator, ToIntFunction<T>
}
return result;
}

}