Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify handling of ignored unassigned shards #12339

Merged
merged 1 commit into from Jul 20, 2015

Conversation

@kimchy
Copy link
Member

commented Jul 20, 2015

Fold ignored unassigned to a UnassignedShards and have simpler handling of them. Also remove the trappy way of adding an ignored unassigned shards today directly to the list, and have dedicated methods for it.

Fold ignored unassigned to a UnassignedShards and have simpler handling of them. Also remove the trapy way of adding an ignored unassigned shards today directly to the list, and have dedicated methods for it.

This change also removes the useless moving of unassigned shards to the end, since anyhow we first, sort those unassigned shards, and second, we now have persistent "store exceptions" that should not cause "dead letter" shard allocation.
@kimchy kimchy force-pushed the kimchy:ignore_unassigned branch to 32445bb Jul 20, 2015
// so we give a chance for other allocations and won't create poison failed allocations
// that can keep other shards from being allocated (because of limits applied on how many
// shards we can start per node)
List<ShardRouting> shardsToMove = Lists.newArrayList();

This comment has been minimized.

Copy link
@martijnvg

martijnvg Jul 20, 2015

Member

great to see this behaviour move to UnassignedShards!

@martijnvg

This comment has been minimized.

Copy link
Member

commented Jul 20, 2015

LGTM

@kimchy kimchy merged commit 32445bb into elastic:master Jul 20, 2015
1 check passed
1 check passed
CLA Commit author is a member of Elasticsearch
Details
@kimchy kimchy deleted the kimchy:ignore_unassigned branch Jul 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.