Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
ThrottlingAllocationDecider should not counting relocating shards #12409
@bleskes can you update the Javadoc for this decider then? It currently says it limits the number of recovery operations (incoming and outgoing) but this change would make it only check incoming.
Also, is this causing an issue? I'm curious if we want the behavior changed.
@dakrone I'm not sure I follow your comment (I don't see the incoming and outgoing part). The problem is that this supposed to limit the amount of shards intializing on a node. This can happen in two ways - a primary assignment (Recover from gateway), a replica assignment and relocation to the node. The later ends up copying the data from the current primary.
At the moment I don't think the intention of this class is limit out going recoveries (we do see using
In both cases the current code is wrong. I opted to make it just count incoming recoveries which I think is the current model. We can make a bigger change later.
@bleskes I was thinking the current javadoc should be changed from:
To something like:
to make it clearer which shard state this is checking. Other than that, the code part LGTM :)