New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy the classloader from the original settings when checking for prompts #12419

Merged
merged 1 commit into from Jul 23, 2015

Conversation

Projects
None yet
3 participants
@jaymode
Member

jaymode commented Jul 23, 2015

Today, when a user provides settings and specifies a classloader to be used, the classloader gets
dropped when we copy the settings to check for prompt entries. This change copies the classloader
when replacing the prompt placeholders and adds a test to ensure the InternalSettingsPreparer
always retains the classloader.

Closes #12340

@clintongormley clintongormley changed the title from copy the classloader from the original settings when checking for pro… to Copy the classloader from the original settings when checking for prompts Jul 23, 2015

@lytvynenkoinvest

This comment has been minimized.

Show comment
Hide comment
@lytvynenkoinvest

lytvynenkoinvest Jul 23, 2015

Hello, is there ETA for fix of this issue?

lytvynenkoinvest commented Jul 23, 2015

Hello, is there ETA for fix of this issue?

@rmuir

View changes

Show outdated Hide outdated .../java/org/elasticsearch/node/internal/InternalSettingsPreparerTests.java
@rmuir

This comment has been minimized.

Show comment
Hide comment
@rmuir

rmuir Jul 23, 2015

Contributor

Looks good to me. just one note

Contributor

rmuir commented Jul 23, 2015

Looks good to me. just one note

copy the classloader from the original settings when checking for pro…
…mpts

Today, when a user provides settings and specifies a classloader to be used, the classloader gets
dropped when we copy the settings to check for prompt entries. This change copies the classloader
when replacing the prompt placeholders and adds a test to ensure the InternalSettingsPreparer
always retains the classloader.

Closes #12340

jaymode added a commit that referenced this pull request Jul 23, 2015

Merge pull request #12419 from jaymode/fix_settings_classloader
Copy the classloader from the original settings when checking for prompts

@jaymode jaymode merged commit f8d9de8 into elastic:master Jul 23, 2015

1 check passed

CLA Commit author has signed the CLA
Details

@jaymode jaymode removed the review label Jul 23, 2015

@lytvynenkoinvest

This comment has been minimized.

Show comment
Hide comment
@lytvynenkoinvest

lytvynenkoinvest Jul 23, 2015

Could you please tell when release with fix of this bug will be built?

lytvynenkoinvest commented Jul 23, 2015

Could you please tell when release with fix of this bug will be built?

@jaymode

This comment has been minimized.

Show comment
Hide comment
@jaymode

jaymode Jul 23, 2015

Member

@lytvynenkoinvest We try to release regularly and the fix will be released with our next bug fix release, 1.7.1.

Member

jaymode commented Jul 23, 2015

@lytvynenkoinvest We try to release regularly and the fix will be released with our next bug fix release, 1.7.1.

@jaymode jaymode deleted the jaymode:fix_settings_classloader branch Jul 23, 2015

@lytvynenkoinvest

This comment has been minimized.

Show comment
Hide comment
@lytvynenkoinvest

lytvynenkoinvest Jul 24, 2015

Are there expectations about the date of the next release?

lytvynenkoinvest commented Jul 24, 2015

Are there expectations about the date of the next release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment