New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cidr mask conversion issue for 0.0.0.0/0 and add tests #12005 #12430

Merged
merged 3 commits into from Jul 27, 2015

Conversation

Projects
None yet
2 participants
@ruflin
Contributor

ruflin commented Jul 23, 2015

This fixes the issue raised in #12005 and adds test to verify it.

@jpountz jpountz self-assigned this Jul 24, 2015

@ruflin

This comment has been minimized.

Show comment
Hide comment
@jpountz

This comment has been minimized.

Show comment
Hide comment
@jpountz

jpountz Jul 27, 2015

Contributor

@ruflin Would you mind signing the CLA. This will be required so that your pull request can be merged.

Contributor

jpountz commented Jul 27, 2015

@ruflin Would you mind signing the CLA. This will be required so that your pull request can be merged.

@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Jul 27, 2015

Contributor

@jpountz I just signed it. BTW: The CLA should probably be updated to Elastic. It is still Elasticsearch.

Contributor

ruflin commented Jul 27, 2015

@jpountz I just signed it. BTW: The CLA should probably be updated to Elastic. It is still Elasticsearch.

@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Jul 27, 2015

Contributor

Test moved up and CLA signed.

Contributor

ruflin commented Jul 27, 2015

Test moved up and CLA signed.

jpountz added a commit that referenced this pull request Jul 27, 2015

Merge pull request #12430 from ruflin/ip_range-mask-fix
Fix cidr mask conversion issue for 0.0.0.0/0 and add tests #12005

@jpountz jpountz merged commit ec79568 into elastic:master Jul 27, 2015

1 check failed

CLA Commit author has not signed the CLA and is not a member of Elasticsearch
Details
@jpountz

This comment has been minimized.

Show comment
Hide comment
@jpountz

jpountz Jul 27, 2015

Contributor

Thanks!

The CLA should probably be updated to Elastic. It is still Elasticsearch.

Elastic is the trade name of the company, but Elasticsearch BV is still the registed name of the company, this is why the CLA still mentions Elasticsearch BV.

Contributor

jpountz commented Jul 27, 2015

Thanks!

The CLA should probably be updated to Elastic. It is still Elasticsearch.

Elastic is the trade name of the company, but Elasticsearch BV is still the registed name of the company, this is why the CLA still mentions Elasticsearch BV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment