Skip to content

Remove subs attribute #124551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

Remove subs attribute #124551

merged 1 commit into from
Mar 11, 2025

Conversation

@reakaleek
Copy link
Member

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@elasticsearchmachine
Copy link
Collaborator

@reakaleek please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.1.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Mar 11, 2025
@reakaleek reakaleek added >docs General docs changes Team:Docs Meta label for docs team labels Mar 11, 2025
@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Mar 11, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@reakaleek reakaleek requested review from a team and luigidellaquila March 11, 2025 11:09
@leemthompo leemthompo added auto-backport Automatically create backport pull requests when merged v9.0.0 labels Mar 11, 2025
luigidellaquila
luigidellaquila approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@luigidellaquila luigidellaquila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@leemthompo leemthompo enabled auto-merge (squash) March 11, 2025 11:13
@leemthompo leemthompo merged commit 435d1db into main Mar 11, 2025
6 of 8 checks passed
@leemthompo leemthompo deleted the reakaleek-patch-1 branch March 11, 2025 11:15
This was referenced Mar 11, 2025
Merged
Merged
@leemthompo
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 9.0

Questions ?

Please refer to the Backport tool documentation

leemthompo pushed a commit to leemthompo/elasticsearch that referenced this pull request Mar 11, 2025
@reakaleek
Remove subs attribute (elastic#124551)
1a3a9bc 
(cherry picked from commit 435d1db)
elasticsearchmachine pushed a commit that referenced this pull request Mar 11, 2025
@leemthompo @reakaleek
Remove subs attribute (#124551) (#124560)
00b1373 
(cherry picked from commit 435d1db)

Co-authored-by: Jan Calanog <nejcalanog@gmail.com>
albertzaharovits pushed a commit to albertzaharovits/elasticsearch that referenced this pull request Mar 13, 2025
@reakaleek @albertzaharovits
Remove subs attribute (elastic#124551)
ed93407
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Mar 13, 2025
@reakaleek @jfreden
Remove subs attribute (elastic#124551)
3db1d45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luigidellaquila luigidellaquila luigidellaquila approved these changes

@leemthompo leemthompo leemthompo approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v9.0.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@reakaleek @elasticsearchmachine @leemthompo @luigidellaquila