-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Misc cleanups in S3BlobContainerRetriesTests
#126101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
elasticsearchmachine
merged 4 commits into
elastic:main
from
DaveCTurner:2025/04/02/S3BlobContainerRetriesTests-request-parsing
Apr 4, 2025
Merged
Misc cleanups in S3BlobContainerRetriesTests
#126101
elasticsearchmachine
merged 4 commits into
elastic:main
from
DaveCTurner:2025/04/02/S3BlobContainerRetriesTests-request-parsing
Apr 4, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simplify multi-object-delete request detection - Replace `AtomicBoolean` with volatile field - Make `ThrottlingDeleteHandler` static
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
DiannaHohensee
approved these changes
Apr 2, 2025
💔 Backport failed
You can use sqren/backport to manually backport by running |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Apr 4, 2025
- Simplify multi-object-delete request detection - Replace `AtomicBoolean` with volatile field Backport of elastic#126101 to `8.x`
|
Backport is #126325 |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 4, 2025
- Simplify multi-object-delete request detection - Replace `AtomicBoolean` with volatile field Backport of #126101 to `8.x`
andreidan
pushed a commit
to andreidan/elasticsearch
that referenced
this pull request
Apr 9, 2025
- Simplify multi-object-delete request detection - Replace `AtomicBoolean` with volatile field - Make `ThrottlingDeleteHandler` static
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
:Distributed Coordination/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
Team:Distributed Coordination
Meta label for Distributed Coordination team
>test
Issues or PRs that are addressing/adding tests
v8.19.0
v9.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AtomicBooleanwith volatile fieldThrottlingDeleteHandlerstatic