Patcher improvements (HDFS) #126449
Merged
Patcher improvements (HDFS) #126449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldematte
added
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
DaveCTurner
reviewed
Apr 8, 2025
...ols-internal/src/main/java/org/elasticsearch/gradle/internal/dependencies/patches/Utils.java
Outdated
Show resolved
Hide resolved
...ternal/src/main/java/org/elasticsearch/gradle/internal/dependencies/patches/PatcherInfo.java
Outdated
Show resolved
Hide resolved
mosche
reviewed
Apr 11, 2025
...ols-internal/src/main/java/org/elasticsearch/gradle/internal/dependencies/patches/Utils.java
Outdated
Show resolved
Hide resolved
DaveCTurner
approved these changes
Apr 11, 2025
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
It'd be slightly nicer to get all the hash mismatches at once, rather than having to update them one-by-one and re-run the build. But it's not that many, this LGTM too.
...ols-internal/src/main/java/org/elasticsearch/gradle/internal/dependencies/patches/Utils.java
Outdated
Show resolved
Hide resolved
prdoyle
reviewed
Apr 11, 2025
...ternal/src/main/java/org/elasticsearch/gradle/internal/dependencies/patches/PatcherInfo.java
Outdated
Show resolved
Hide resolved
Contributor
Author
I like it, Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patchers transform specific classes in some "broken" dependencies to ensure they behave correctly (fixing a bug, disabling some undesired or dangerous behaviour, updating calls to deprecated or removed method overloads).
If we upgrade one of the dependencies we patch, we have a concerns that the patchers may not work against the classes in the new version.
This PR addresses this concern by introducing a check on the SHA256 digest of the class, to ensure we are operating on the same bytes the patcher was designed for; if the digest changes that means the class has been changed (e.g. for a dependency update). If that happens, we break the build process with a specific error, so we can double check that the patchers still work against the new classes.
Extracted from #126326
Relates to ES-11279