Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethrow exception during recovery finalization even if source is not broken #12667

Merged

Conversation

Projects
None yet
4 participants
@s1monw
Copy link
Contributor

s1monw commented Aug 5, 2015

Today we miss to throw / rethrow an recovery exception if it happens during
the finalization of phase 1 if the source files are not affected. Even worse
this can cause some dataloss if the reason for this exception is a failure of
deleting a corruption marker or similar pre-existing corruptions since we continue
with the recovery and mark the target shared as started which will in-turn open
an engine with an empty index.

@jpountz jpountz changed the title Rethrow exception during recovery finalization even if source if not broken Rethrow exception during recovery finalization even if source is not broken Aug 5, 2015

@jpountz

This comment has been minimized.

Copy link
Contributor

jpountz commented Aug 5, 2015

LGTM
But this part of the code is not really my cup of tea, so probably needs another review.

@s1monw s1monw added the review label Aug 5, 2015

@s1monw

This comment has been minimized.

Copy link
Contributor Author

s1monw commented Aug 5, 2015

@kimchy @bleskes can you take a look

@kimchy

This comment has been minimized.

Copy link
Member

kimchy commented Aug 5, 2015

LGTM

Rethrow exception during recovery finalization even if source if not …
…broken

Today we miss to throw / rethrow an recovery exception if it happens during
the finalization of phase 1 if the source files are not affected. Even worse
this can cause some dataloss if the reason for this exception is a failure of
deleting a corruption marker or similar pre-existing corruptions since we continue
with the recovery and mark the target shared as started which will in-turn open
an engine with an empty index.

@s1monw s1monw force-pushed the s1monw:rethrow_exception_during_finalization branch to abf763c Aug 5, 2015

@s1monw s1monw merged commit abf763c into elastic:master Aug 5, 2015

1 check passed

CLA Commit author is a member of Elasticsearch
Details
@s1monw

This comment has been minimized.

Copy link
Contributor Author

s1monw commented Aug 5, 2015

pushed also to 1.6 and 1.7

@s1monw s1monw deleted the s1monw:rethrow_exception_during_finalization branch Aug 5, 2015

@clintongormley clintongormley removed the review label Aug 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.