Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bats testing: Remove useless systemctl check #12724

Merged

Conversation

@spinscale
Copy link
Member

commented Aug 7, 2015

Bats testing uncovered a useless systemctl check, that resulted in an
error, because the systemctl file was uninstalled, but we hoped to
check for an explicetely configured SystemExitCode.

In addition we did not reload the systemctl configuration when uninstalling
elasticsearch, which now is fixed as well.

Closes #12682

@nik9000

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2015

LGTM

Bats testing uncovered a useless systemctl check, that resulted in an
error, because the systemctl file was uninstalled, but we hoped to
check for an explicetely configured SystemExitCode.

In addition we did not reload the systemctl configuration when uninstalling
elasticsearch, which now is fixed as well.

Closes #12682
@spinscale spinscale force-pushed the spinscale:1508-issue-12682-systemctl-goes-wrong branch to b6016b6 Aug 7, 2015
@spinscale spinscale merged commit b6016b6 into elastic:master Aug 7, 2015
1 check passed
1 check passed
CLA Commit author is a member of Elasticsearch
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.