New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't cache percolator query on loading percolators #12862

Merged
merged 1 commit into from Aug 13, 2015

Conversation

Projects
None yet
4 participants
@s1monw
Contributor

s1monw commented Aug 13, 2015

No need to load catch this query since it's cheap and not reused.
If we cache it, it can cause assertions to be tripped since this
method is executed during postRecovery phase and might still run while
nodes are shutdown in tests.

here are related test failures:

http://build-us-00.elastic.co/job/elasticsearch-20-oracle-jdk6/11
http://build-us-00.elastic.co/job/elasticsearch-20-suse/5/

@rjernst

This comment has been minimized.

Show comment
Hide comment
@rjernst

rjernst Aug 13, 2015

Member

LGTM

Member

rjernst commented Aug 13, 2015

LGTM

Don't cache percolator query on loading percolators
No need to load catch this query since it's cheap and not reused.
If we cache it, it can cause assertions to be tripped since this
method is executed during postRecovery phase and might still run while
nodes are shutdown in tests.
@martijnvg

This comment has been minimized.

Show comment
Hide comment
@martijnvg

martijnvg Aug 13, 2015

Member

LGTM2

Member

martijnvg commented Aug 13, 2015

LGTM2

@s1monw s1monw merged commit 1f41a8c into elastic:master Aug 13, 2015

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@clintongormley clintongormley added v2.0.0-beta1 and removed >test labels Aug 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment