Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java api: remove execution from TermsQueryBuilder as it has no effect #12884

Merged

Conversation

javanna
Copy link
Member

@javanna javanna commented Aug 14, 2015

Also introduced ParseField for execution in TermsQueryParser so proper deprecation warnings get printed out when requested.

@alexksikes
Copy link
Contributor

LGTM, perhaps mention it as well in migration doc. I'm putting a refers to #12042 so we know where this comes from.

@javanna javanna added the v2.0.0 label Aug 14, 2015
@javanna javanna force-pushed the enhancement/terms_query_remove_execution branch from c3c8f97 to a32addb Compare August 14, 2015 17:01
@jpountz
Copy link
Contributor

jpountz commented Aug 18, 2015

LGTM

@javanna javanna removed the review label Aug 18, 2015
Also introduced ParseField for execution in TermsQueryParser so proper deprecation warnings get printed out when requested.

Closes elastic#12884
@javanna javanna force-pushed the enhancement/terms_query_remove_execution branch from a32addb to 8e93ac5 Compare August 18, 2015 12:57
@javanna javanna merged commit 8e93ac5 into elastic:master Aug 18, 2015
@javanna
Copy link
Member Author

javanna commented Aug 21, 2015

This is labelled 2.0 but it hasn't been backported to 2.0 yet, will just have to clarify when I can go ahead and backport.

@s1monw
Copy link
Contributor

s1monw commented Aug 21, 2015

it's baked enough in master please go ahead and cherry-pick it

javanna added a commit that referenced this pull request Aug 21, 2015
Also introduced ParseField for execution in TermsQueryParser so proper deprecation warnings get printed out when requested.

Closes #12884
@javanna
Copy link
Member Author

javanna commented Aug 21, 2015

backported, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants