Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove attemped (not working) support for array in not query parser #12890

Merged
merged 2 commits into from Aug 18, 2015

Conversation

javanna
Copy link
Member

@javanna javanna commented Aug 14, 2015

Query DSL: remove attemped (not working) support for array in not query parser.

Looking at this parser I don't see how it can parse an inner query wrapped in an array, although it makes little sense.

@jpountz
Copy link
Contributor

jpountz commented Aug 18, 2015

LGTM

@javanna javanna removed the review label Aug 18, 2015
Also introduced ParseField for execution in TermsQueryParser so proper deprecation warnings get printed out when requested.

Closes elastic#12884
@javanna javanna force-pushed the enhancement/not_parser_remove_array branch from c24d730 to 501a199 Compare August 18, 2015 12:59
@javanna javanna merged commit 501a199 into elastic:master Aug 18, 2015
@javanna javanna added the v2.1.0 label Aug 18, 2015
@jpountz
Copy link
Contributor

jpountz commented Aug 21, 2015

@javanna This is labeled as 2.0 but I can't find a commit on the 2.0 branch, did you forget to backport or should it be only labeled as a 2.1 change?

@javanna
Copy link
Member Author

javanna commented Aug 21, 2015

hey @jpountz I am waiting for beta1 to go out so I can backport.

javanna added a commit that referenced this pull request Aug 21, 2015
@javanna
Copy link
Member Author

javanna commented Aug 21, 2015

it is now backported to 2.0 as well.

@clintongormley clintongormley changed the title Query DSL: remove attemped (not working) support for array in not query parser Remove attemped (not working) support for array in not query parser Aug 25, 2015
@clintongormley clintongormley added :Search/Search Search-related issues that do not fall into other categories and removed :Query DSL labels Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :Search/Search Search-related issues that do not fall into other categories v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants