Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten ClusterModule and add more tests #12916

Merged
merged 1 commit into from Aug 16, 2015

Conversation

@rjernst
Copy link
Member

commented Aug 16, 2015

The ClusterModule contained a couple submodules. This moves the
functionality from those modules into ClusterModule. Two of those
had to do with DynamicSettings. This change also cleans up
how DynamicSettings are built, and enforces they are added, with
validators, in ClusterModule.

See #12783

The ClusterModule contained a couple submodules. This moves the
functionality from those modules into ClusterModule. Two of those
had to do with DynamicSettings. This change also cleans up
how DynamicSettings are built, and enforces they are added, with
validators, in ClusterModule.

See #12783.
@rjernst rjernst force-pushed the rjernst:module_culling branch to 008dc8e Aug 16, 2015
@s1monw

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2015

LGTM

rjernst added a commit that referenced this pull request Aug 16, 2015
Flatten ClusterModule and add more tests
@rjernst rjernst merged commit 9974b79 into elastic:master Aug 16, 2015
1 check passed
1 check passed
CLA Commit author is a member of Elasticsearch
Details
@rjernst

This comment has been minimized.

Copy link
Member Author

commented Aug 16, 2015

I will backport to 2.0 branch after the beta is released.

@rjernst rjernst deleted the rjernst:module_culling branch Aug 16, 2015
rjernst added a commit that referenced this pull request Aug 19, 2015
Flatten ClusterModule and add more tests
@rjernst rjernst added v2.0.0-beta1 and removed v2.0.0 labels Aug 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.