Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use preferIPv6Addresses for sort order, not preferIPv4Stack #12951

Merged
merged 1 commit into from Aug 18, 2015

Conversation

@rmuir
Copy link
Contributor

commented Aug 18, 2015

java.net.preferIPv6Addresses is a better choice. preferIPv4Stack is a nuclear option
and you just won't even bind to any IPv6 addresses. This reduces confusion.

java.net.preferIPv6Addresses is a better choice. preferIPv4Stack is a nuclear option
and you just won't even bind to any IPv6 addresses. This reduces confusion.
@dakrone

This comment has been minimized.

Copy link
Member

commented Aug 18, 2015

LGTM

@rmuir rmuir added the v2.0.0-beta1 label Aug 18, 2015
rmuir added a commit that referenced this pull request Aug 18, 2015
Use preferIPv6Addresses for sort order, not preferIPv4Stack
@rmuir rmuir merged commit 34635a4 into elastic:master Aug 18, 2015
1 check passed
1 check passed
CLA Commit author is a member of Elasticsearch
Details
@clintongormley clintongormley removed the v2.1.0 label Nov 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.