New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin modules before (almost all) others #13061

Merged
merged 1 commit into from Aug 23, 2015

Conversation

Projects
None yet
3 participants
@rjernst
Member

rjernst commented Aug 23, 2015

This change makes modules added by plugins come before others, as it was
before #12783. The order of configuration, and thereby binding, happens
in the order modules are received, and without this change, some plugins
can get insane guice errors (500mb stack trace).

Internal: Add plugin modules before (almost all) others
This change makes modules added by plugins come before others, as it was
before #12783. The order of configuration, and thereby binding, happens
in the order modules are received, and without this change, some plugins
can get *insane* guice errors (500mb stack trace).
@s1monw

This comment has been minimized.

Show comment
Hide comment
@s1monw

s1monw Aug 23, 2015

Contributor

LGTM thanks!

Contributor

s1monw commented Aug 23, 2015

LGTM thanks!

rjernst added a commit that referenced this pull request Aug 23, 2015

Merge pull request #13061 from rjernst/injection_craziness
Add plugin modules before (almost all) others

@rjernst rjernst merged commit b1d9635 into elastic:master Aug 23, 2015

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@rjernst rjernst deleted the rjernst:injection_craziness branch Aug 23, 2015

s1monw added a commit to s1monw/elasticsearch that referenced this pull request Aug 25, 2015

Merge pull request #13061 from rjernst/injection_craziness
Add plugin modules before (almost all) others

s1monw added a commit to s1monw/elasticsearch that referenced this pull request Aug 25, 2015

@clintongormley clintongormley removed the v2.1.0 label Nov 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment