New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported `rewrite` option from match query builder #13069

Merged
merged 1 commit into from Aug 24, 2015

Conversation

Projects
None yet
4 participants
@cbuescher
Member

cbuescher commented Aug 24, 2015

The rewrite option has been removed from the parser with commit da5fa6c and won't parse anymore, however we still have a setter for it in the builder that gets rendered out when used and potentially leads to parsing errors. This PR removes the setter for the unsupported rewrite option.

Query DSL: Remove unsupported `rewrite` option from match query builder
The `rewrite` option has been removed from the parser with
commit da5fa6c and won't parse anymore, however we still
have a setter for it in the builder that gets rendered out
when used and potentially leads to parsing errors. This PR
removes the setter for the unsupported `rewrite` option.
@javanna

This comment has been minimized.

Show comment
Hide comment
@javanna

javanna Aug 24, 2015

Member

good catch, LGTM I wonder if we should do the same with multi_match too.

Member

javanna commented Aug 24, 2015

good catch, LGTM I wonder if we should do the same with multi_match too.

@jpountz

This comment has been minimized.

Show comment
Hide comment
@jpountz

jpountz Aug 24, 2015

Contributor

LGTM

Contributor

jpountz commented Aug 24, 2015

LGTM

cbuescher added a commit that referenced this pull request Aug 24, 2015

Merge pull request #13069 from cbuescher/rm-matchQuery-rewrite
Remove unsupported `rewrite` option from match query builder

@cbuescher cbuescher merged commit c7a8386 into elastic:master Aug 24, 2015

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@cbuescher cbuescher added the v2.1.0 label Aug 24, 2015

@cbuescher

This comment has been minimized.

Show comment
Hide comment
@cbuescher

cbuescher Aug 24, 2015

Member

Thanks, will look into multi_match as well.

Member

cbuescher commented Aug 24, 2015

Thanks, will look into multi_match as well.

@cbuescher cbuescher deleted the cbuescher:rm-matchQuery-rewrite branch Mar 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment