New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues developing Elasticsearch with Eclipse #13070

Merged
merged 2 commits into from Aug 24, 2015

Conversation

Projects
None yet
3 participants
@nik9000
Contributor

nik9000 commented Aug 24, 2015

  1. Fix importing Elasticsearch into eclipse with mvn eclipse:clean && mvn eclipse:eclipse. It was creating projects with the same name which Eclipse was less than happy with.
  2. Fix the launch script. It was failing on the security manager among other things. This disables the security manager when launching Elasticsearch using the pre-packaged launch configuration. We can re-enable it later. I just wanted to get it working again because it can really speed development in some areas.

nik9000 added some commits Aug 21, 2015

Fix importing into eclipse
Renaming the distribution's artifactIds to "elasticsearch" caused the eclipse
import process to balk. Fix those modules by moving their eclipse package to
"[groupId].[artifactId]".
Eclipse: Fix launch configuration
We had a file in dev-tools/ElasticSearch.launch which tried to launch
elasticsearch but failed somewhat epically because of the security manager
and files having moved. This recreates it with
`-Des.security.manager.enabled=false` to get it working again. Its not as nice
as testing with the security manager in place but its better than waiting
minutes for maven to package and startup elasticsearch.
@dadoonet

This comment has been minimized.

Show comment
Hide comment
@dadoonet

dadoonet Aug 24, 2015

Member

LGTM

Member

dadoonet commented Aug 24, 2015

LGTM

@dadoonet

This comment has been minimized.

Show comment
Hide comment
@dadoonet

dadoonet Aug 24, 2015

Member

Don't you think you should backport it in 2.0 BTW?

Member

dadoonet commented Aug 24, 2015

Don't you think you should backport it in 2.0 BTW?

@nik9000 nik9000 added the v2.0.0 label Aug 24, 2015

@nik9000

This comment has been minimized.

Show comment
Hide comment
@nik9000

nik9000 Aug 24, 2015

Contributor

Don't you think you should backport it in 2.0 BTW?

That is probably a good idea, yeah. The issue comes up in 2.0, certainly.

Contributor

nik9000 commented Aug 24, 2015

Don't you think you should backport it in 2.0 BTW?

That is probably a good idea, yeah. The issue comes up in 2.0, certainly.

nik9000 added a commit that referenced this pull request Aug 24, 2015

Merge pull request #13070 from nik9000/eclipse_fix
Fix some issues developing Elasticsearch with Eclipse

@nik9000 nik9000 merged commit 0de493e into elastic:master Aug 24, 2015

1 check passed

CLA Commit author has signed the CLA
Details
@nik9000

This comment has been minimized.

Show comment
Hide comment
@nik9000

nik9000 Aug 24, 2015

Contributor

Merged into 2.0 and master.

Contributor

nik9000 commented Aug 24, 2015

Merged into 2.0 and master.

@clintongormley clintongormley added v2.0.0-beta2 and removed v2.0.0 labels Sep 14, 2015

@clintongormley clintongormley removed the v2.1.0 label Nov 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment