Use try to close query response and unmute testThatRemoteErrorsAreWrapped
#131090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawankartik-elastic
added
>non-issue
>test
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
pawankartik-elastic
changed the title
testThatRemoteErrorsAreWrapped: use try to close query response and unmute testtry to close query response and unmute testThatRemoteErrorsAreWrapped
javanna
approved these changes
Jul 11, 2025
pawankartik-elastic
added a commit
to pawankartik-elastic/elasticsearch
that referenced
this pull request
Jul 11, 2025
…lastic#131090) Explicitly close the ES|QL query response obtained in the test to avoid potential leak. (cherry picked from commit f536069) # Conflicts: # muted-tests.yml
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 17, 2025
…lastic#131090) Explicitly close the ES|QL query response obtained in the test to avoid potential leak.
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 17, 2025
…lastic#131090) Explicitly close the ES|QL query response obtained in the test to avoid potential leak.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was added way back in April and there are only 5 failures out of 20,000+ executions. All these failures occurred on 8th July. I looked at the logs for a run and saw a few other test failures with error messages pointing towards certain "leaks". I suspect that these failures are isolated to that run and have nothing to do with the test itself. Nevertheless, I made a small change to close out the ES|QL response we're obtaining in the test to be on the safer side and also unmuted the test.
Resolves #130794.