New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move position_offset_gap default change #13111

Merged
merged 1 commit into from Aug 25, 2015

Conversation

Projects
None yet
3 participants
@nik9000
Contributor

nik9000 commented Aug 25, 2015

Until a couple of hours ago we expected the position_offset_gap to default
to 0 in 2.0 and 100 in 2.1. We decided it was worth backporting that new
default to 2.0. So now that its backported we need to teach 2.1 that 2.0
also defaults to 100.

@nik9000

This comment has been minimized.

Show comment
Hide comment
@nik9000

nik9000 Aug 25, 2015

Contributor

@xuzha would you mind having a look at this? I think it makes master consistent with 2.0.

Contributor

nik9000 commented Aug 25, 2015

@xuzha would you mind having a look at this? I think it makes master consistent with 2.0.

@@ -25,13 +25,3 @@ GET /my_index/_search?scroll=2m
Scroll requests sorted by `_doc` have been optimized to more efficiently resume
from where the previous request stopped, so this will have the same performance
characteristics as the former `scan` search type.
=== Mapping changes

This comment has been minimized.

This comment has been minimized.

@nik9000

nik9000 Aug 25, 2015

Contributor

Good call. Added.

@nik9000

nik9000 Aug 25, 2015

Contributor

Good call. Added.

@xuzha

This comment has been minimized.

Show comment
Hide comment
@xuzha

xuzha Aug 25, 2015

Contributor

Left a minor comment.

LGTM

Contributor

xuzha commented Aug 25, 2015

Left a minor comment.

LGTM

[Mapping] Move position_offset_gap default change
Until a couple of hours ago we expected the position_offset_gap to default
to 0 in 2.0 and 100 in 2.1. We decided it was worth backporting that new
default to 2.0. So now that its backported we need to teach 2.1 that 2.0
also defaults to 100.

Closes #7268
@nik9000

This comment has been minimized.

Show comment
Hide comment
@nik9000

nik9000 Aug 25, 2015

Contributor

Squashed.

Contributor

nik9000 commented Aug 25, 2015

Squashed.

nik9000 added a commit that referenced this pull request Aug 25, 2015

Merge pull request #13111 from nik9000/position_offset_gap_in_2.0
[Mapping] Move position_offset_gap default change

@nik9000 nik9000 merged commit e8834cc into elastic:master Aug 25, 2015

1 check passed

CLA Commit author has signed the CLA
Details

@nik9000 nik9000 changed the title from [Mapping] Move position_offset_gap default change to Move position_offset_gap default change Aug 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment