New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort thread pools by name in Nodes Stats #13121

Merged
merged 1 commit into from Aug 31, 2015

Conversation

Projects
None yet
4 participants
@tlrx
Member

tlrx commented Aug 26, 2015

This pull request adds a very simple sort of thread pools (by their names) so that the Nodes Stats output is more predictive.

@bleskes

View changes

Show outdated Hide outdated core/src/main/java/org/elasticsearch/threadpool/ThreadPoolStats.java Outdated
@bleskes

This comment has been minimized.

Show comment
Hide comment
@bleskes

bleskes Aug 28, 2015

Member

Left one minor comment

Member

bleskes commented Aug 28, 2015

Left one minor comment

@bleskes bleskes self-assigned this Aug 28, 2015

@nik9000

This comment has been minimized.

Show comment
Hide comment
@nik9000

nik9000 Aug 28, 2015

Contributor

Its ok with me though I think google collection's Lists is banned now.

Contributor

nik9000 commented Aug 28, 2015

Its ok with me though I think google collection's Lists is banned now.

@tlrx

This comment has been minimized.

Show comment
Hide comment
@tlrx

tlrx Aug 31, 2015

Member

@bleskes @nik9000 Thanks for your reviews. I updated the code according to your comment, would you like to have a look?

Member

tlrx commented Aug 31, 2015

@bleskes @nik9000 Thanks for your reviews. I updated the code according to your comment, would you like to have a look?

@bleskes

This comment has been minimized.

Show comment
Hide comment
@bleskes

bleskes Aug 31, 2015

Member

LGTM

Member

bleskes commented Aug 31, 2015

LGTM

@tlrx

This comment has been minimized.

Show comment
Hide comment
@tlrx

tlrx Aug 31, 2015

Member

Thanks @bleskes

Member

tlrx commented Aug 31, 2015

Thanks @bleskes

@tlrx tlrx removed the review label Aug 31, 2015

@tlrx tlrx merged commit dbbecce into elastic:master Aug 31, 2015

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@tlrx tlrx deleted the tlrx:sort-nodes-stats-threapools-by-name branch Aug 31, 2015

@tlrx tlrx added the v2.0.0 label Sep 2, 2015

@clintongormley clintongormley added v2.0.0-beta2 and removed v2.0.0 labels Sep 14, 2015

@clintongormley clintongormley removed the v2.1.0 label Nov 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment