New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of tuple as a method parameter #13135

Merged
merged 1 commit into from Aug 27, 2015

Conversation

Projects
None yet
4 participants
@jasontedor
Member

jasontedor commented Aug 27, 2015

This commit removes all instances of
org.elasticsearch.common.collect.Tuple as a method parameter.

Note for the reviewer: this pull request must either be integrated into the 2.0 branch before 2.0 GA, or held back until there is a home for 3.0. This is due to the fact that there are breaking public surface API changes contained in this pull request.

Closes #10787

Remove usage of tuple as a method parameter
This commit removes all instances of
org.elasticsearch.common.collect.Tuple as a method parameter.

Closes #10787
@rjernst

This comment has been minimized.

Show comment
Hide comment
@rjernst

rjernst Aug 27, 2015

Member

This looks great, +1!
I don't think we need to worry about backcompat here. These are internal apis, and whether this is in 2.0 or 2.1, I think the break is fine to make.

Member

rjernst commented Aug 27, 2015

This looks great, +1!
I don't think we need to worry about backcompat here. These are internal apis, and whether this is in 2.0 or 2.1, I think the break is fine to make.

@s1monw

This comment has been minimized.

Show comment
Hide comment
@s1monw

s1monw Aug 27, 2015

Contributor

LGTM +1 to go into 2.0?

Contributor

s1monw commented Aug 27, 2015

LGTM +1 to go into 2.0?

@jasontedor jasontedor added the v2.0.0 label Aug 27, 2015

jasontedor added a commit that referenced this pull request Aug 27, 2015

Merge pull request #13135 from jasontedor/fix/eliminate-tuple-as-a-me…
…thod-parameter

Remove usage of tuple as a method parameter

@jasontedor jasontedor merged commit a867a95 into elastic:master Aug 27, 2015

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@jasontedor jasontedor deleted the jasontedor:fix/eliminate-tuple-as-a-method-parameter branch Aug 27, 2015

jasontedor added a commit that referenced this pull request Aug 27, 2015

Remove usage of tuple as a method parameter
This commit backports the fix #13135 for #10787 to 2.0 from master.

@clintongormley clintongormley added v2.0.0-beta2 and removed v2.0.0 labels Sep 14, 2015

@clintongormley clintongormley removed the v2.1.0 label Nov 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment