Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove and forbid use of com.google.common.collect.Lists #13170

Merged
merged 1 commit into from Aug 28, 2015
Merged

Remove and forbid use of com.google.common.collect.Lists #13170

merged 1 commit into from Aug 28, 2015

Conversation

jasontedor
Copy link
Member

This commit removes and now forbids all uses of
com.google.common.collect.Lists across the codebase. This is the first
of many steps in the eventual removal of Guava as a dependency.

}

public static <E> ArrayList<E> asArrayList(E first, E... other) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with these for now, but do we really need them long term? It is no different complexity-wise than doing a prepend on an arraylist?

@rjernst
Copy link
Member

rjernst commented Aug 28, 2015

LGTM, I left one comment that is just a thought for the future.

This commit removes and now forbids all uses of
com.google.common.collect.Lists across the codebase. This is the first
of many steps in the eventual removal of Guava as a dependency.
jasontedor added a commit that referenced this pull request Aug 28, 2015
Remove and forbid use of com.google.common.collect.Lists
@jasontedor jasontedor merged commit 3e88cc0 into elastic:master Aug 28, 2015
@jasontedor jasontedor deleted the fix/lists-be-gone branch August 28, 2015 02:19
@jasontedor jasontedor removed the review label Aug 28, 2015
@s1monw
Copy link
Contributor

s1monw commented Aug 28, 2015

PR of the month! 👍

@jasontedor jasontedor mentioned this pull request Aug 31, 2015
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants