New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default _cat verbose to false #13180

Merged
merged 2 commits into from Aug 28, 2015

Conversation

Projects
None yet
4 participants
@nik9000
Contributor

nik9000 commented Aug 28, 2015

#8927 changed the _cat APIs to default to verbose. This was released in 2.0.0-beta1, but then we decided to revert to previous behaviour.

Closes #13156

@nik9000

This comment has been minimized.

Show comment
Hide comment
@nik9000

nik9000 Aug 28, 2015

Contributor

I'm still running the tests for this. Its a one line Java change but its far reaching.

Note: this reverts a breaking API change. Its now no longer breaking.

Contributor

nik9000 commented Aug 28, 2015

I'm still running the tests for this. Its a one line Java change but its far reaching.

Note: this reverts a breaking API change. Its now no longer breaking.

@nik9000 nik9000 changed the title from [CAT] Default verbose to false to Default verbose to false Aug 28, 2015

@nik9000 nik9000 changed the title from Default verbose to false to Default _cat verbose to false Aug 28, 2015

@nik9000 nik9000 added the review label Aug 28, 2015

@jasontedor

This comment has been minimized.

Show comment
Hide comment
@jasontedor

jasontedor Aug 28, 2015

Member

LGTM.

Member

jasontedor commented Aug 28, 2015

LGTM.

nik9000 added a commit that referenced this pull request Aug 28, 2015

@nik9000 nik9000 merged commit 5463947 into elastic:master Aug 28, 2015

1 check passed

CLA Commit author has signed the CLA
Details
@nik9000

This comment has been minimized.

Show comment
Hide comment
@nik9000

nik9000 Aug 28, 2015

Contributor

Merged to master.

Rerunning tests in 2.0 and will merge there once they pass.

Contributor

nik9000 commented Aug 28, 2015

Merged to master.

Rerunning tests in 2.0 and will merge there once they pass.

@grantr

This comment has been minimized.

Show comment
Hide comment
@grantr

grantr commented Aug 28, 2015

Thanks @nik9000!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment