New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing plugin without checksums ends up downloading from github #13197

Merged
merged 1 commit into from Aug 29, 2015

Conversation

Projects
None yet
3 participants
@dadoonet
Member

dadoonet commented Aug 29, 2015

bin/plugin install lmenezes/elasticsearch-kopf/develop
-> Installing lmenezes/elasticsearch-kopf/develop...
Trying http://download.elastic.co/lmenezes/elasticsearch-kopf/elasticsearch-kopf-develop.zip ...
Trying http://search.maven.org/remotecontent?filepath=lmenezes/elasticsearch-kopf/develop/elasticsearch-kopf-develop.zip ...
Trying https://oss.sonatype.org/service/local/repositories/releases/content/lmenezes/elasticsearch-kopf/develop/elasticsearch-kopf-develop.zip ...
Trying https://github.com/lmenezes/elasticsearch-kopf/archive/develop.zip ...
Downloading .................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................DONE
Verifying https://github.com/lmenezes/elasticsearch-kopf/archive/develop.zip checksums if available ...
Trying https://github.com/lmenezes/elasticsearch-kopf/archive/master.zip ...
Downloading ....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................DONE
Verifying https://github.com/lmenezes/elasticsearch-kopf/archive/master.zip checksums if available ...

This happens because we don't have anymore ElasticsearchWrapperException here but standard java exceptions.

Closes #13196.

@s1monw

This comment has been minimized.

Show comment
Hide comment
@s1monw

s1monw Aug 29, 2015

Contributor

I think we should remove that catch block altogether and just rethrow the first exception from the HttpDownloadHelper instead of wrapping it in yet another IOException

Contributor

s1monw commented Aug 29, 2015

I think we should remove that catch block altogether and just rethrow the first exception from the HttpDownloadHelper instead of wrapping it in yet another IOException

@dadoonet

This comment has been minimized.

Show comment
Hide comment
@dadoonet

dadoonet Aug 29, 2015

Member

@s1monw I pushed a new commit.

Member

dadoonet commented Aug 29, 2015

@s1monw I pushed a new commit.

@s1monw

View changes

Show outdated Hide outdated ...c/main/java/org/elasticsearch/common/http/client/HttpDownloadHelper.java Outdated
@s1monw

This comment has been minimized.

Show comment
Hide comment
@s1monw

s1monw Aug 29, 2015

Contributor

left another comment

Contributor

s1monw commented Aug 29, 2015

left another comment

@@ -378,9 +369,6 @@ private URLConnection openConnection(URL aSource) throws IOException {
responseCode == HttpURLConnection.HTTP_MOVED_TEMP ||
responseCode == HttpURLConnection.HTTP_SEE_OTHER) {
String newLocation = httpConnection.getHeaderField("Location");
String message = aSource

This comment has been minimized.

@dadoonet

dadoonet Aug 29, 2015

Member

@s1monw I removed also this because it's not used in our code. It's unrelated to the change though.

@dadoonet

dadoonet Aug 29, 2015

Member

@s1monw I removed also this because it's not used in our code. It's unrelated to the change though.

@dadoonet

This comment has been minimized.

Show comment
Hide comment
@dadoonet

dadoonet Aug 29, 2015

Member

@s1monw pushed another commit.

Member

dadoonet commented Aug 29, 2015

@s1monw pushed another commit.

@s1monw

This comment has been minimized.

Show comment
Hide comment
@s1monw

s1monw Aug 29, 2015

Contributor

LGTM

Contributor

s1monw commented Aug 29, 2015

LGTM

Installing plugin without checksums ends up downloading from github
```sh
bin/plugin install lmenezes/elasticsearch-kopf/develop
-> Installing lmenezes/elasticsearch-kopf/develop...
Trying http://download.elastic.co/lmenezes/elasticsearch-kopf/elasticsearch-kopf-develop.zip ...
Trying http://search.maven.org/remotecontent?filepath=lmenezes/elasticsearch-kopf/develop/elasticsearch-kopf-develop.zip ...
Trying https://oss.sonatype.org/service/local/repositories/releases/content/lmenezes/elasticsearch-kopf/develop/elasticsearch-kopf-develop.zip ...
Trying https://github.com/lmenezes/elasticsearch-kopf/archive/develop.zip ...
Downloading .................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................DONE
Verifying https://github.com/lmenezes/elasticsearch-kopf/archive/develop.zip checksums if available ...
Trying https://github.com/lmenezes/elasticsearch-kopf/archive/master.zip ...
Downloading ....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................DONE
Verifying https://github.com/lmenezes/elasticsearch-kopf/archive/master.zip checksums if available ...
```

This happens because we don't have anymore ElasticsearchWrapperException here but standard java exceptions.

Closes #13196.

@dadoonet dadoonet merged commit 03bb285 into elastic:master Aug 29, 2015

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@dadoonet dadoonet removed the review label Aug 29, 2015

@dadoonet dadoonet deleted the dadoonet:fix/13196-pluginmanager-checksum branch Aug 29, 2015

@clintongormley clintongormley added v2.0.0-beta2 and removed v2.0.0 labels Sep 14, 2015

@clintongormley clintongormley removed the v2.1.0 label Nov 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment