New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update list of available os stats #13198

Merged
merged 1 commit into from Aug 31, 2015

Conversation

Projects
None yet
3 participants
@lmenezes
Contributor

lmenezes commented Aug 29, 2015

os cpu information is no longer exposed through the nodes stats api.

Btw, will this be exposed through any other api? Or os cpu information will just no longer be available at all?

update list of available os stats
os cpu information is no longer exposed through the nodes stats api
@lmenezes

This comment has been minimized.

Show comment
Hide comment
@lmenezes

lmenezes Aug 31, 2015

Contributor

@clintongormley was removing this intentional? I actually miss the os cpu and also the load average for 1min, 5min, 15min?

Contributor

lmenezes commented Aug 31, 2015

@clintongormley was removing this intentional? I actually miss the os cpu and also the load average for 1min, 5min, 15min?

@clintongormley

This comment has been minimized.

Show comment
Hide comment
@clintongormley

clintongormley Aug 31, 2015

Member

@lmenezes it was intentional. We removed libsigar because it is unmaintained and started causing segfaults. For now, we're relying only on stats provided by the JVM. Later we may expand the stats with OS-specific implementations but first things first.

Member

clintongormley commented Aug 31, 2015

@lmenezes it was intentional. We removed libsigar because it is unmaintained and started causing segfaults. For now, we're relying only on stats provided by the JVM. Later we may expand the stats with OS-specific implementations but first things first.

@lmenezes

This comment has been minimized.

Show comment
Hide comment
@lmenezes

lmenezes Aug 31, 2015

Contributor

@clintongormley ah cool, good to know 👍

Contributor

lmenezes commented Aug 31, 2015

@clintongormley ah cool, good to know 👍

@tlrx

This comment has been minimized.

Show comment
Hide comment
@tlrx

tlrx Aug 31, 2015

Member

@lmenezes Thanks for your contribution. Could you please sign the CLA so that I can push this in? Thanks

Member

tlrx commented Aug 31, 2015

@lmenezes Thanks for your contribution. Could you please sign the CLA so that I can push this in? Thanks

@lmenezes

This comment has been minimized.

Show comment
Hide comment
@lmenezes

lmenezes Aug 31, 2015

Contributor

@tlrx I have already signed this, but I have done it again :)

Contributor

lmenezes commented Aug 31, 2015

@tlrx I have already signed this, but I have done it again :)

@tlrx

This comment has been minimized.

Show comment
Hide comment
@tlrx

tlrx Aug 31, 2015

Member

@lmenezes awesome, thanks!

Member

tlrx commented Aug 31, 2015

@lmenezes awesome, thanks!

@tlrx tlrx removed the review label Aug 31, 2015

tlrx added a commit that referenced this pull request Aug 31, 2015

Merge pull request #13198 from lmenezes/patch-2
update list of available os stats

@tlrx tlrx merged commit f4bcbe2 into elastic:2.0 Aug 31, 2015

1 check passed

CLA Commit author has signed the CLA
Details

@tlrx tlrx added the v2.0.0 label Aug 31, 2015

@lmenezes lmenezes deleted the lmenezes:patch-2 branch Aug 31, 2015

@tlrx tlrx added the v2.1.0 label Aug 31, 2015

@clintongormley clintongormley added v2.0.0-beta2 and removed v2.0.0 labels Sep 14, 2015

@clintongormley clintongormley removed the v2.1.0 label Nov 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment