New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport remaining packaging tests work #13223

Merged
merged 2 commits into from Aug 31, 2015

Conversation

Projects
None yet
3 participants
@nik9000
Contributor

nik9000 commented Aug 31, 2015

This backports the packaging test work that I did in master and hadn't yet backported to 2.0.

nik9000 added some commits Aug 14, 2015

Test: Remove ES_CLEAN_BEFORE_TEST
In the bats test ES_CLEAN_BEFORE_TEST was used to clean the environment
before running the tests. Unfortunately the tests don't work unless you
specify it every time. This removes that option and always runs the clean.
Tests: Clean up the tar tests
1. Move `clean_before_test` to the first test so its more explicit.
2. Move `skip_not_tar_gz` to setup because it was run first in every test.
3. Remove calls to `run` that only check the status. Its simpler to just
execute the command. Its better because std-out will be captured and replayed
on error.
4. Switch from `su` to `sudo` because `su` was breaking `bats`'s error
reporting.
@nik9000

This comment has been minimized.

Show comment
Hide comment
@nik9000

nik9000 Aug 31, 2015

Contributor

Tests are passing for me locally with these patches which is a good thing!

Contributor

nik9000 commented Aug 31, 2015

Tests are passing for me locally with these patches which is a good thing!

@tlrx

This comment has been minimized.

Show comment
Hide comment
@tlrx

tlrx Aug 31, 2015

Member

@nik9000 Changes also looks good

Member

tlrx commented Aug 31, 2015

@nik9000 Changes also looks good

nik9000 added a commit that referenced this pull request Aug 31, 2015

Merge pull request #13223 from nik9000/bats_2.0
Backport remaining packaging tests work

@nik9000 nik9000 merged commit 2072aeb into elastic:2.0 Aug 31, 2015

1 check passed

CLA Commit author has signed the CLA
Details

@clintongormley clintongormley added v2.0.0-beta2 and removed v2.0.0 labels Sep 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment