From af4c057ce6e60148cf5ea9c2ab276c1293364a34 Mon Sep 17 00:00:00 2001 From: Tim Vernum Date: Thu, 21 Aug 2025 14:35:35 +1000 Subject: [PATCH] Fix Glob suffixTest (#133282) If suffix contained a '#' then suffix + '#' + randomString() could end with suffix (even if the randomString did not equal suffix) --- .../core/src/test/java/org/elasticsearch/core/GlobTests.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libs/core/src/test/java/org/elasticsearch/core/GlobTests.java b/libs/core/src/test/java/org/elasticsearch/core/GlobTests.java index 1025b8d42e7ca..12dbb3f0313b8 100644 --- a/libs/core/src/test/java/org/elasticsearch/core/GlobTests.java +++ b/libs/core/src/test/java/org/elasticsearch/core/GlobTests.java @@ -96,7 +96,10 @@ public void testSuffixMatch() { var pattern = "*" + suffix; assertMatch(pattern, suffix); assertMatch(pattern, randomAsciiString(randomIntBetween(1, 30)) + suffix); - assertNonMatch(pattern, suffix + "#" + randomValueOtherThan(suffix, () -> randomAsciiString(randomIntBetween(1, 30)))); + assertNonMatch( + pattern, + randomValueOtherThanMany(str -> str.endsWith(suffix), () -> suffix + "#" + randomAsciiString(randomIntBetween(1, 30))) + ); assertNonMatch(pattern, suffix.substring(0, suffix.length() - 1)); assertNonMatch(pattern, suffix.substring(1)); }