New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IndexNameExpressionResolver should not ignore any wildcards #13384

Merged
merged 1 commit into from Sep 15, 2015

Conversation

Projects
None yet
4 participants
@xuzha
Contributor

xuzha commented Sep 8, 2015

Suffix wildcard case should work for the expression which only has one wildcard in the end.

Fix for #13334.

@nik9000

View changes

Show outdated Hide outdated ...java/org/elasticsearch/cluster/metadata/IndexNameExpressionResolver.java
@nik9000

This comment has been minimized.

Show comment
Hide comment
@nik9000

nik9000 Sep 14, 2015

Contributor

Left a small comment otherwise it LGTM.

Contributor

nik9000 commented Sep 14, 2015

Left a small comment otherwise it LGTM.

@xuzha

This comment has been minimized.

Show comment
Hide comment
@xuzha

xuzha Sep 14, 2015

Contributor

Thx @nik9000 :-)

Contributor

xuzha commented Sep 14, 2015

Thx @nik9000 :-)

@xuzha

This comment has been minimized.

Show comment
Hide comment
@xuzha

xuzha Sep 14, 2015

Contributor

Do we need this for 2.0 and 2.1 @clintongormley ?

Contributor

xuzha commented Sep 14, 2015

Do we need this for 2.0 and 2.1 @clintongormley ?

@nik9000

This comment has been minimized.

Show comment
Hide comment
@nik9000

nik9000 Sep 14, 2015

Contributor

Almost certainly 2.1 (2.x branch) and probably not 2.0. Its a bug and doesn't have much chance of breaking anything so I'm for putting it in 2.0 as well.

Contributor

nik9000 commented Sep 14, 2015

Almost certainly 2.1 (2.x branch) and probably not 2.0. Its a bug and doesn't have much chance of breaking anything so I'm for putting it in 2.0 as well.

@martijnvg

This comment has been minimized.

Show comment
Hide comment
@martijnvg

martijnvg Sep 15, 2015

Member

LGTM

@xuzha @nik9000 @clintongormley I think this bugfix should be backported to 2.x and 2.0

Member

martijnvg commented Sep 15, 2015

LGTM

@xuzha @nik9000 @clintongormley I think this bugfix should be backported to 2.x and 2.0

@xuzha xuzha merged commit c6da8d5 into elastic:master Sep 15, 2015

1 check passed

CLA Commit author is a member of Elasticsearch
Details
@xuzha

This comment has been minimized.

Show comment
Hide comment
@xuzha

xuzha Sep 15, 2015

Contributor

Thanks @nik9000 and @martijnvg for the review.

Changes are in master c6da8d5, 2.x defe1de, 2.0 0e0c89a

Contributor

xuzha commented Sep 15, 2015

Thanks @nik9000 and @martijnvg for the review.

Changes are in master c6da8d5, 2.x defe1de, 2.0 0e0c89a

@martijnvg

This comment has been minimized.

Show comment
Hide comment
@martijnvg

martijnvg Sep 15, 2015

Member

thank you @xuzha!

Member

martijnvg commented Sep 15, 2015

thank you @xuzha!

@xuzha xuzha deleted the xuzha:ending-wildcard branch Sep 15, 2015

@clintongormley clintongormley added v2.0.0-rc1 and removed v2.0.0 labels Oct 7, 2015

@clintongormley clintongormley removed the v2.1.0 label Nov 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment