Retrievers: Refactor retriever builder tests #134799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioanatia
added
>test
ioanatia
commented
Sep 16, 2025
server/src/main/java/org/elasticsearch/search/retriever/CompoundRetrieverBuilder.java
Outdated
Show resolved
Hide resolved
ioanatia
requested review from
Mikep86,
dimitris-athanasiou and
mridula-s109
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
mridula-s109
approved these changes
Sep 16, 2025
Mikep86
reviewed
Sep 16, 2025
...lugin/rank-rrf/src/test/java/org/elasticsearch/xpack/rank/AbstractRetrieverBuilderTests.java
Outdated
Show resolved
Hide resolved
...lugin/rank-rrf/src/test/java/org/elasticsearch/xpack/rank/AbstractRetrieverBuilderTests.java
Outdated
Show resolved
Hide resolved
...lugin/rank-rrf/src/test/java/org/elasticsearch/xpack/rank/AbstractRetrieverBuilderTests.java
Show resolved
Hide resolved
...plugin/rank-rrf/src/test/java/org/elasticsearch/xpack/rank/rrf/RRFRetrieverBuilderTests.java
Outdated
Show resolved
Hide resolved
Mikep86
approved these changes
Sep 16, 2025
Comment on lines
153
to
154
| T rewrittenLinear = (T) rewritten; | ||
| assertEquals(retriever.rankWindowSize(), rewrittenLinear.rankWindowSize()); |
There was a problem hiding this comment.
Two nits here:
rewrittenLinearis leftover from when this was only for the linear retriever- We don't need to check
rankWindowSizehere anymore, that's done inassertCompoundRetriever
There was a problem hiding this comment.
thanks - just addressed this too
dimitris-athanasiou
approved these changes
Sep 16, 2025
gmjehovich
pushed a commit
to gmjehovich/elasticsearch
that referenced
this pull request
Sep 18, 2025
phananh1010
added a commit
to phananh1010/elasticsearch
that referenced
this pull request
Sep 23, 2025
BASE=5ce0c649d6b0ebe7c731eb23157489e8d3c46633 HEAD=8c7939c511b854052233c03dc866f469270829d3 Branch=main
phananh1010
added a commit
to phananh1010/elasticsearch
that referenced
this pull request
Oct 1, 2025
BASE=5ce0c649d6b0ebe7c731eb23157489e8d3c46633 HEAD=8c7939c511b854052233c03dc866f469270829d3 Branch=main
phananh1010
added a commit
to phananh1010/elasticsearch
that referenced
this pull request
Oct 7, 2025
BASE=5ce0c649d6b0ebe7c731eb23157489e8d3c46633 HEAD=8c7939c511b854052233c03dc866f469270829d3 Branch=main
phananh1010
added a commit
to phananh1010/elasticsearch
that referenced
this pull request
Oct 17, 2025
BASE=5ce0c649d6b0ebe7c731eb23157489e8d3c46633 HEAD=8c7939c511b854052233c03dc866f469270829d3 Branch=main
phananh1010
added a commit
to phananh1010/elasticsearch
that referenced
this pull request
Oct 23, 2025
BASE=5ce0c649d6b0ebe7c731eb23157489e8d3c46633 HEAD=8c7939c511b854052233c03dc866f469270829d3 Branch=main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
AbstractRetrieverBuilderTeststhat copies some of the methods inLinearRetrieverBuilderTests.We then extend this abstract class in both
LinearRetrieverBuilderTestsandRRFRetrieverBuilderTestsremoving duplication and making sure we have consistent testing for both retrievers.This is a prerequisite for adding support for querying multiple indices with the RRF simplified retriever.
And I think it will also help with testing in #132680