Remove and forbid use of several com.google.common.util. classes #13524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like it! |
| com.google.common.util.concurrent.ListenableFuture | ||
| com.google.common.util.concurrent.SettableFuture | ||
| com.google.common.util.concurrent.Futures | ||
| com.google.common.util.concurrent.MoreExecutors |
There was a problem hiding this comment.
Can you move these to dev-tools/src/main/resources/forbidden/all-signatures.txt as in #13523?
This commit replaces: * com.google.common.util.concurrent.ListenableFuture * com.google.common.util.concurrent.SettableFuture * com.google.common.util.concurrent.Futures * com.google.common.util.concurrent.MoreExecutors And forbits its usage via forbidden APIs. This is one of many steps in the eventual removal of Guava as a dependency. Relates to elastic#13224
s1monw
force-pushed
the
forbid_guava_concurrent
branch
from
3ff8a0b
to
7b0f086
Compare
|
rebased with master |
72 tasks
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces:
And forbids its usage via forbidden APIs. This is one of
many steps in the eventual removal of Guava as a dependency.
Relates to #13224