Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date math index names should work too when an index doesn't exist #13570

Merged

Conversation

@martijnvg
Copy link
Member

commented Sep 15, 2015

Date math index names should also work when indexing documents into a non existing index.

@javanna

View changes

core/src/main/java/org/elasticsearch/cluster/metadata/IndexNameExpressionResolver.java Outdated
* @return If the specified string is data math expression then this method returns the resolved expression.
*/
public String resolveDateMathExpression(String dateExpression) {
return dateMathExpressionResolver.resolveExpression(dateExpression, new Context(null, null));

This comment has been minimized.

Copy link
@javanna

javanna Sep 23, 2015

Member

the initialization of the context with two null arguments makes me wonder why we don't need those arguments there.

This comment has been minimized.

Copy link
@martijnvg

martijnvg Sep 25, 2015

Author Member

I'll add an inline comment why null is okay here.

@javanna

This comment has been minimized.

Copy link
Member

commented Sep 23, 2015

left a small comment, LGTM otherwise

@martijnvg martijnvg force-pushed the martijnvg:date_math_expressions_for_create_index_api branch Sep 25, 2015

@martijnvg martijnvg force-pushed the martijnvg:date_math_expressions_for_create_index_api branch to 04cfbe3 Sep 25, 2015

@martijnvg martijnvg merged commit 04cfbe3 into elastic:master Sep 25, 2015

1 check passed

CLA Commit author is a member of Elasticsearch
Details
martijnvg added a commit that referenced this pull request Sep 25, 2015
martijnvg added a commit that referenced this pull request Sep 25, 2015

@clintongormley clintongormley added v2.0.0-rc1 and removed v2.0.0 labels Oct 7, 2015

@clintongormley clintongormley removed the v2.1.0 label Nov 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.