[DiskBBQ] add method for calculate centroids during merge #137039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
Team:Search Relevance
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
benwtrent
approved these changes
Oct 23, 2025
Member
benwtrent
left a comment
benwtrent
left a comment
There was a problem hiding this comment.
yessir, I agree with the split, we should have a "merge time" calculator.
iverase
added
the
auto-merge-without-approval
fzowl
pushed a commit
to voyage-ai/elasticsearch
that referenced
this pull request
Nov 3, 2025
…7039) We currently se the same API method to compute centroids during flush and during merge. In order to explore improvements on how we compute centroids during merge (e.g reusing some of the existing centroids), this commit adds a new API method for calculating centroids during merging. They implementation currently fowards the request to the calcualtion of centroids during flush. I moved the computation of the global centroid to CentroidAssignments as it feels it belongs there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently se the same API method to compute centroids during flush and during merge. In order to explore improvements on how we compute centroids during merge (e.g reusing some of the existing centroids), this commit adds a new API method for calculating centroids during merging. They implementation currently fowards the request to the calcualtion of centroids during flush.
I moved the computation of the global centroid to CentroidAssignments as it feels it belongs there.